Fix: CUDA build flags and linker compatibility for Windows and Linux#90
Open
CellularSyntax wants to merge 1 commit intoNX-AI:mainfrom
Open
Fix: CUDA build flags and linker compatibility for Windows and Linux#90CellularSyntax wants to merge 1 commit intoNX-AI:mainfrom
CellularSyntax wants to merge 1 commit intoNX-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the build logic in cuda_init.py to fix platform-specific issues during CUDA extension compilation on Windows.
Fixes:
Tested on: Windows 11 (Anaconda, CUDA 12.8, PyTorch 2.4.0)
Not tested on Linux, but preserves the original behavior for Linux systems.